On Mon, Jan 11, 2021 at 3:27 PM jb <j...@kdenlive.org> wrote: > Hi all, > > The strobe filter, recently added, seems to have a few issues, that I'd > like to bring up so that we can either fix or blacklist it in Kdenlive: > > 1- It does not explicitly ask for the mlt_image_rgb24a image format, but > only processes if the frame has this format. Is this the wanted behavior ? > It might be confusing to the user as the filter only operates on some file > formats and not some others... > > That is not a problem. This is not the only filter that operates in more than one image format. Compatibility with more image formats rather than less is a good thing. It should not only operate on some file formats; it depends more on what format is requested based on what you are doing with the alpha channel.
> 2- It crashes trying to access invalid memory at line 80: > > image[i] = 0; > > If it helps, I have a patch proposal that fixes both issues for me: > > > https://github.com/j-b-m/mlt/commit/c4ae4796f72a150a49cfa740c479a755c5f54d8b > > I fail to see how your patch improves the second point since they both assume the image pointer is not NULL and that width and height are correct. Maybe you can improve your points. I find rewriting the for loop to be less informative than a more direct fix. In any case, please address the author of this filter in your e-mail because he might not be using the mailing list.
_______________________________________________ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
