On Sun, Aug 15, 2021 at 03:08:47PM -0700, Dan Dennedy wrote:
> On Sun, Aug 15, 2021 at 1:02 PM amindfv--- via Mlt-devel <
> mlt-devel@lists.sourceforge.net> wrote:
> 
> > More recent versions of Kdenlive are putting properties in entries. For
> > example:
> >
> >     <entry producer="producer1" in="00:00:00.000" out="00:05:12.804">
> >      <property name="kdenlive:id">2</property>
> >     </entry>
> >
> >
> > and:
> >
> >     <entry producer="producer3" in="00:05:12.846" out="01:34:03.420">
> >      <property name="kdenlive:id">2</property>
> >      <property name="kdenlive:activeeffect">1</property>
> >      <filter id="filter6">
> >      ...
> >
> > This technically isn't part of the spec (at least according to
> > src/modules/xml/mlt-xml.dtd). Would there be any downside to changing the
> > MLT XML DTD from...:
> >
> >     <!ELEMENT entry (producer | playlist | tractor | multitrack | filter |
> > transition | chain)* >
> >
> > ...to:
> >
> >     <!ELEMENT entry (property*,(producer | playlist | tractor | multitrack
> > | filter | transition | chain)*) >
> >
> >
> >
> I do not see any downside, but I have not tested that property as a child
> of entry works. Assuming it works because it is working in a
> Kdenlve release (and not simply a bug in development code), please go ahead
> and submit a pull request. Thanks

Yes, this isn't just development code; it's the Kdenlive version in Debian 
Stable now.

I don't currently have a Github account but here's the patch:

    diff --git a/src/modules/xml/mlt-xml.dtd b/src/modules/xml/mlt-xml.dtd
    index 67fa8540..6ec0e834 100644
    --- a/src/modules/xml/mlt-xml.dtd
    +++ b/src/modules/xml/mlt-xml.dtd
    @@ -77,7 +77,7 @@
         out      CDATA    #IMPLIED
         title    CDATA    #IMPLIED
     >
    -<!ELEMENT entry (producer | playlist | tractor | multitrack | filter | 
transition | chain)* >
    +<!ELEMENT entry (property*,(producer | playlist | tractor | multitrack | 
filter | transition | chain)*) >
     <!ATTLIST entry
         producer IDREF    #IMPLIED
         in       CDATA    #IMPLIED


Cheers,
Tom



_______________________________________________
Mlt-devel mailing list
Mlt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mlt-devel

Reply via email to