On Oct 26, 2010, at 10:39 AM, John Rose wrote:
> This is a large set of miscellaneous API adjustments that takes
> account of intensive JSR 292 Expert Group work since the JVM
> Language Summit and JavaOne.
>
> http://cr.openjdk.java.net/~jrose/6981777/webrev.01/
src/share/classes/java/dyn/MethodHandles.java:
833 * of {...@code Object} arguments and an {...@code Object} return type.
There is something wrong with this line (accidental paste?).
src/share/classes/java/dyn/package-info.java:
90 * The first pair of bytes bytes after the tag must be an index to a
{...@code CONSTANT_MethodHandle}
One bytes too much.
225 * Any {...@code varargs} modifier on the bootstrap method is
irrelevant,
226 * since is no provision for adapting a bootstrap method with
227 * {...@link java.dyn.MethodHandle#asCollector asCollector}.
This sounds odd.
330 * or an {...@code Object} array of reference to all the arguments (if
there are two or more),
references?
src/share/classes/sun/dyn/CallSiteImpl.java:
66 if (false) // switch when invokeGeneric works
Doesn't invokeGeneric work now?
src/share/classes/sun/dyn/util/Wrapper.java:
118 /** Does the JVM verifier allow allow a variable of this wrapper's
One allow too much.
Otherwise looks good.
-- Christian
_______________________________________________
mlvm-dev mailing list
mlvm-dev@openjdk.java.net
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
