On Nov 11, 2010, at 4:34 PM, Rémi Forax wrote: > BTW, in int2prim() all comments are wrong. > Instead of > > assertEquals( false, (boolean) InvokeDynamic.foo(i)); // > void -> boolean > > > it should be > > assertEquals( false, (boolean) InvokeDynamic.foo(i)); // int -> > boolean
That's right. But this method is still commented because it produces the exception we talked about earlier. I'm not sure if I should push what I have or wait until we have a fix for that. Today I looked at the sun.dyn.util.ValueConversions unbox functions and I wonder if these should also handle other types than just their boxing type. All unbox functions take an Object but only cast to their boxing type instead of doing an instanceof check. But I'm not an expert here... -- Christian _______________________________________________ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
