On Mar 23, 2011, at 10:10 AM, John Rose wrote:
> http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.00/
>
> Summary: JDK code for package and class renaming from java.dyn to
> java.lang.invoke.
>
> Includes certain other small changes:
> - move remaining (miscellaneous) contents of sun.dyn to sun.invoke
> - make minor revisions to documentation during Public Review
> - remove the out-of-scope term "SAM type" from documentation and code
> - delete unused methods and classes
> - make minor (API-invisible) code cleanups
make/common/Release.gmk:
make/docs/CORE_PKGS.gmk:
make/modules/modules.config:
Copyright year update missing.
src/share/classes/java/lang/ClassValue.java:
+ // /** @deprecated This override, which is implementation-specific, will
be removed for PFD. */
+ // public final int hashCode() { return hashCode; }
+ // private final int hashCode = HASH_CODES.getAndAdd(0x61c88647);
+ // private static final AtomicInteger HASH_CODES = new AtomicInteger();
Why comment it and not simply remove it?
src/share/classes/java/lang/invoke/MethodHandles.java:
+ * <p>
* This method is equivalent to the following code:
- * <code>
+ * <p><blockquote><pre>
* {@link #dropArguments(MethodHandle,int,List) dropArguments}(target,
pos, Arrays.asList(valueTypes))
* </code>
+ * </pre></blockquote>
</code> should be removed too.
src/share/classes/java/lang/invoke/package-info.java:
- * All failures are reported by an {@link java.dyn.InvokeDynamicBootstrapError
InvokeDynamicBootstrapError},
+ * All failures are reported by an {@link
java.lang.invoke.InvokeDynamicBootstrapError InvokeDynamicBootstrapError},
That's BootstrapMethodError.
src/share/classes/sun/invoke/anon/AnonymousClassLoader.java:
Just a question: is noJVMSupport() a JVM entry point? Because it's private
static and not used in this class.
Otherwise looks good.
-- Christian
_______________________________________________
mlvm-dev mailing list
[email protected]
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
