Overall it seems ok. A few minor oddities: MethodHandle.java
variable arity is sometimes hyphenated. It seems more correct without but be consistent. AdapterMethodHandle.java: The new value srcSlot appears unused. Should this just go away: - if (argCount <= 2) return false; // must be a swap, not a rotate + //if (argCount <= 2) return false; // must be a swap, not a rotate tom On May 25, 2011, at 3:30 AM, John Rose wrote: > This is the last major bundle of changes for JDK 7. > http://cr.openjdk.java.net/~jrose/7032323/webrev.00/ > > (Note: This is an engineering code review. The associated API documents are > also under review and are about to be finalized by the Expert Group. Here is > a recent version: http://cr.openjdk.java.net/~jrose/pres/indy-javadoc-mlvm/ ) > > Additions: > - ConstantCallSite.<init>(MethodType, MethodHandle) (hook for self-binding) > - MethodHandles.asFixedArity (inverse to asVarargsCollector) > > Renames: > - MethodHandles.convertArguments => MethodHandle.asType > - MethodHandles.asInstance => MethodHandleProxies.asInterfaceInstance > - MethodHandles.*wrapperInstance* => MethodHandleProxies.*wrapperInstance* > > Semantic changes: > - more explicit rules for asType and explicitCastArguments > - rules for void returns on filter and fold transforms > - MHs.spreadInvoker and MHs.invoker made more regular > > Clarifications: > - lots of @throws declarations > - more example snippets in the javadoc > - document varargs in more places > > Bug fixes: > - MH.toString method needs to be compliant > - security manager checks as documented > - unboxing of primitives as documented > - permuteArguments failures on long/int mixes > - more testing for invalid arguments > - tweak guardWithTest > > Deletions: > - Some javadoc in MethodHandle and package-info deleted, when it is redundant > with JDK7 version of JLS or JVMS > > _______________________________________________ > mlvm-dev mailing list > mlvm-dev@openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev _______________________________________________ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
