On 09/05/2014 04:07 PM, Morris Meyer wrote:
Remi,

That assert in a static method could be pulled out to a static block.

Regarding the asserts in the LambdaForms code, my feeling is that in code that is still in the process of being refactored, that they are critical to maintain integrity. After the dust settles, creating a debugging subclass used for testing, and moving some of the asserts to unit tests might be helpful for performance.

        --mm

Hi Morris,
I fully agree.

Rémi


On 9/5/14, 2:59 AM, Remi Forax wrote:

On 09/03/2014 07:46 PM, John Rose wrote:
On Sep 3, 2014, at 10:35 AM, Mark Roos <mr...@roos.com> wrote:

 From Morris

         All that assert laden code is nice to see.

I just finished watching a video from Doug Lea where he mentioned that having asserts can inhibit inlining due to the additional byte codes. So he sadly does not use them due to
performance issues.

Does anyone have any insights on this?
Yep.

http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028450.html
https://bugs.openjdk.java.net/browse/JDK-6316156

yes, sadly, it's sometimes a real problem, here is a thread on core-lib [1] about removing an assert in Integer.valueOf that allow JDart to have acceptable perf.


— John

Rémi

[1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-April/010007.html

_______________________________________________
mlvm-dev mailing list
mlvm-dev@openjdk.java.net
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

_______________________________________________
mlvm-dev mailing list
mlvm-dev@openjdk.java.net
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

_______________________________________________
mlvm-dev mailing list
mlvm-dev@openjdk.java.net
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

_______________________________________________
mlvm-dev mailing list
mlvm-dev@openjdk.java.net
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

Reply via email to