Hi,
I have updated the webrev
http://cr.openjdk.java.net/~kshefov/8058695/webrev.03/
-Konstantin
On 02.10.2014 5:10, Igor Ignatyev wrote:
Konstantin,
+ private TestMethods(String name, int maxArity) {
+ this.name = name;
+ this.maxArity = maxArity;
+ }
+
private TestMethods(String name) {
this.name = name;
+ this.maxArity = Helper.MAX_ARITY;
}
please call TestMethods(String, int) from TestMethods(String) instead
of copy&paste.
Thanks,
Igor
On 10/01/2014 05:46 PM, Konstantin Shefov wrote:
Thanks for reviewing
http://cr.openjdk.java.net/~kshefov/8058695/webrev.02
-Konstantin
On 01.10.2014 17:30, Igor Ignatyev wrote:
Hi Konstantin,
0. could you please introduce a ctor which sets the default value for
'maxArity' and use it instead of explicitly passed 'Helper.MAX_ARITY'?
1. there is a existing solution for your case w/ access to an private
field of an outer class:
int desiredArity = Helper.RNG.nextInt(super.maxArity);
otherwise changes look good to me.
Thanks,
Igor
----- Original Message -----
From: konstantin.she...@oracle.com
To: vladimir.x.iva...@oracle.com, igor.ignat...@oracle.com
Cc: core-libs-...@openjdk.java.net, mlvm-dev@openjdk.java.net
Sent: Wednesday, October 1, 2014 4:20:54 PM GMT +04:00 Abu Dhabi /
Muscat
Subject: Re: [9] Review request : JDK-8058695: [TESTBUG] Reinvokers
with arity >253 can't be cached
Hi,
I have updated the webrev:
http://cr.openjdk.java.net/~kshefov/8058695/webrev.01
Also I will move fix to JDK-8058733 to other request.
-Konstantin
On 24.09.2014 19:54, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058695
Webrev is http://cr.openjdk.java.net/~kshefov/8058695/webrev.00/
There is also a fix to
https://bugs.openjdk.java.net/browse/JDK-8058733 in this diff.
Thanks
-Konstantin
_______________________________________________
mlvm-dev mailing list
mlvm-dev@openjdk.java.net
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
