On Oct 16, 2014, at 10:43 AM, Konstantin Shefov <konstantin.she...@oracle.com> wrote:
> Gently reminder > > On 14.10.2014 16:58, Konstantin Shefov wrote: >> Hello, >> >> Please review the test bug fix >> https://bugs.openjdk.java.net/browse/JDK-8059070 >> Webrev is http://cr.openjdk.java.net/~kshefov/8059070/webrev.00/ >> 45 private static final long TIMEOUT = 300000; Does jtreg define a system property for this value? and is 300s the same as what jtreg defines as the default? The online documentation (jtreg -onlineHelp) says the default is 2 minutes, but that might be out of date. Might be more readable to use: TimeUnit.SECONDS.toMillis(300); 143 long passedTime = new Date().getTime() - startTime; Why don't you use System.currentTimeMillis() instead of "new Date().getTime()" ? 145 double timeoutFactor = new Double(System.getProperty("test.timeout.factor", "1.0")); You can that pull out into a static and perhaps merge with TIMEOUT. 147 if (avgIterTime > 2 * remainTime) { That seems sufficient but it will be interesting to see if intermittent failures still occur due to high variance. Paul.
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
