Looks good now.

-Aleksey.

On 11/19/2014 01:30 PM, Vladimir Ivanov wrote:
> Hm, I remember I fixed that long time ago... Seems like I chose a stale
> patch. Sorry for that. Updated webrev in place.
> 
> Best regards,
> Vladimir Ivanov
> 
> On 11/19/14, 3:38 AM, Aleksey Shipilev wrote:
>> On 11/18/2014 11:23 PM, Vladimir Ivanov wrote:
>>> http://cr.openjdk.java.net/~vlivanov/8063135/webrev.00/
>>> https://bugs.openjdk.java.net/browse/JDK-8063135
>>
>> Broken array index here:
>>
>>   69         TRACE_METHOD_LINKAGE      = (Boolean) values[3];
>>   70         COMPILE_THRESHOLD         = (Integer) values[5];
>>
>> Also, how does it pass the tests? It should fail with AIOBE during
>> MethodHandleStatics::<clinit>, since
>>
>>   53         final Object[] values = new Object[7];
>>   ...
>>   72         PROFILE_LEVEL             = (Integer) values[7];
>>
>> Thanks,
>> -Aleksey.
>>
>>
>>
>> _______________________________________________
>> mlvm-dev mailing list
>> mlvm-dev@openjdk.java.net
>> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
>>


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
mlvm-dev mailing list
mlvm-dev@openjdk.java.net
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

Reply via email to