Hey Claes, though far away from being an expert on the subject matter, I have some very minor comments if you don't mind.
ClassSpecializer.java L510: * For example, a concrete species for two reference and one integral bound values have a shape like the following: Should be imho: L510: * For example, a concrete species for two references and one integral bound value has a shape like the following: LambdaFormBuffer.java: L333: if (oldFns.size() == 0) return this; Could be: L333: if (oldFns.isEmpty()) return this; Cheers, Christoph > -----Original Message----- > From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On > Behalf Of Claes Redestad > Sent: Monday, November 13, 2017 5:35 PM > To: core-libs-dev <core-libs-...@openjdk.java.net> > Cc: mlvm-dev@openjdk.java.net > Subject: RFR: 8184777: Factor out species generation logic from > BoundMethodHandle > > Hi, > > this patch factors out the BoundMethodHandle species data class > generation to a new ClassSpecializer facility. > > While currently semantically neutral, this will make it possible to reuse > the > facility in other places. > > Webrev: http://cr.openjdk.java.net/~redestad/8184777/open.00/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8184777 > > Performance wise this adds a very small (~20k bytecode) amount of work to > the initialization costs of BMHs, which we expect will be more than repaid as > we apply the ClassSpecializer elsewhere. > > Thanks! > > /Claes _______________________________________________ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
