The patch titled
yet another fix for setup-bus.c/x86 merge
has been added to the -mm tree. Its filename is
yet-another-fix-for-setup-busc-x86-merge.patch
Patches currently in -mm which might be from [EMAIL PROTECTED] are
yet-another-fix-for-setup-busc-x86-merge.patch
From: Ivan Kokshaysky <[EMAIL PROTECTED]>
There is a slight disagreement between setup-bus.c code and traditional
x86 PCI setup wrt which recourses are invalid vs resources that are
free for further allocations.
Precisely, in the setup-bus.c, if we failed to allocate some resource,
we nullify "start" and "flags" fields, but *not* the "end" one.
But x86 pcibios_enable_resources() does the following check:
if (!r->start && r->end) {
printk(KERN_ERR "PCI: Device %s not available because of resource
collisions\n", pci_name(dev));
return -EINVAL;
which means that the device owning the offending resource cannot be
enabled.
In particular, this breaks cardbus behind the normal decode p2p bridge -
the cardbus code from setup-bus.c requests rather large IO and MEM windows,
and if it fails, the socket is completely unavailable. Which is wrong, as
the yenta code is capable to allocate smaller windows.
Signed-off-by: Ivan Kokshaysky <[EMAIL PROTECTED]>
Cc: Greg KH <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/pci/setup-bus.c | 1 +
1 files changed, 1 insertion(+)
diff -puN drivers/pci/setup-bus.c~yet-another-fix-for-setup-busc-x86-merge
drivers/pci/setup-bus.c
--- devel/drivers/pci/setup-bus.c~yet-another-fix-for-setup-busc-x86-merge
2005-07-06 18:22:15.000000000 -0700
+++ devel-akpm/drivers/pci/setup-bus.c 2005-07-06 18:22:15.000000000 -0700
@@ -74,6 +74,7 @@ pbus_assign_resources_sorted(struct pci_
idx = res - &list->dev->resource[0];
if (pci_assign_resource(list->dev, idx)) {
res->start = 0;
+ res->end = 0;
res->flags = 0;
}
tmp = list;
_
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
