The patch titled
mm: remove stale comment from swapfile.c
has been added to the -mm tree. Its filename is
remove-stale-comment-from-swapfilec.patch
Patches currently in -mm which might be from [EMAIL PROTECTED] are
comment-typo-fix.patch
shmem_populate-avoid-an-useless-check-and-some-comments.patch
add-swap-cache-mapping-comment.patch
remove-implied-vm_ops-check.patch
remove-stale-comment-from-swapfilec.patch
x86_64-remove-duplicated-sys_time64.patch
uml-rename-kconfig-files-to-be-like-the-other-arches.patch
ptrace-i386-fix-syscall-audit-interaction-with-singlestep.patch
uml-support-ptrace-adds-the-host-sysemu-support-for-uml-and-general-usage.patch
uml-support-reorganize-ptrace_sysemu-support.patch
uml-support-add-ptrace_sysemu_singlestep-option-to-i386.patch
sysemu-fix-sysaudit--singlestep-interaction.patch
uml-support-sysemu-slight-cleanup-and-speedup.patch
uml-workaround-gdb-problems-on-debugging.patch
uml-fix-sigwinch-handler-race-while-waiting-for-signals.patch
uml-fixes-performance-regression-in-activate_mm-and-thus-exec.patch
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]>
Seems like on 2.4.9.4 this comment got out of sync ;-)
I'm not completely sure on which basis we don't need any more to do as the
comment suggests, but it seems that when faulting in a second time the same
swap page, can_share_swap_page() returns false, and we do an early COW break,
so there's no need to write-protect the page.
No idea why we don't defer the COW break.
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]>
Cc: Hugh Dickins <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
mm/swapfile.c | 5 +----
1 files changed, 1 insertion(+), 4 deletions(-)
diff -puN mm/swapfile.c~remove-stale-comment-from-swapfilec mm/swapfile.c
--- 25/mm/swapfile.c~remove-stale-comment-from-swapfilec Wed Aug 17
14:51:10 2005
+++ 25-akpm/mm/swapfile.c Wed Aug 17 14:51:10 2005
@@ -398,10 +398,7 @@ void free_swap_and_cache(swp_entry_t ent
}
/*
- * Always set the resulting pte to be nowrite (the same as COW pages
- * after one process has exited). We don't know just how many PTEs will
- * share this swap entry, so be cautious and let do_wp_page work out
- * what to do if a write is requested later.
+ * Since we're swapping it in, we mark it as old.
*
* vma->vm_mm->page_table_lock is held.
*/
_
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
