The patch titled
     core_pattern: fix up a few miscellaneous bugs
has been removed from the -mm tree.  Its filename was
     core_pattern-fix-up-a-few-miscellaneous-bugs.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
Subject: core_pattern: fix up a few miscellaneous bugs
From: Neil Horman <[EMAIL PROTECTED]>

Fix do_coredump to detect a crash in the user mode helper process and abort
the attempt to recursively dump core to another copy of the helper process,
potentially ad-infinitum.

[EMAIL PROTECTED]: cleanups]
Signed-off-by: Neil Horman <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Cc: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 fs/exec.c |   17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff -puN fs/exec.c~core_pattern-fix-up-a-few-miscellaneous-bugs fs/exec.c
--- a/fs/exec.c~core_pattern-fix-up-a-few-miscellaneous-bugs
+++ a/fs/exec.c
@@ -1762,14 +1762,27 @@ int do_coredump(long signr, int exit_cod
                goto fail_unlock;
 
        if (ispipe) {
-               core_limit = RLIM_INFINITY;
                helper_argv = argv_split(GFP_KERNEL, corename+1, &helper_argc);
                /* Terminate the string before the first option */
                delimit = strchr(corename, ' ');
                if (delimit)
                        *delimit = '\0';
+               delimit = strrchr(helper_argv[0], '/');
+               if (delimit)
+                       delimit++;
+               else
+                       delimit = helper_argv[0];
+               if (!strcmp(delimit, current->comm)) {
+                       printk(KERN_NOTICE "Recursive core dump detected, "
+                                       "aborting\n");
+                       goto fail_unlock;
+               }
+
+               core_limit = RLIM_INFINITY;
+
                /* SIGPIPE can happen, but it's just never processed */
-               if(call_usermodehelper_pipe(corename+1, helper_argv, NULL, 
&file)) {
+               if (call_usermodehelper_pipe(corename+1, helper_argv, NULL,
+                               &file)) {
                        printk(KERN_INFO "Core dump to %s pipe failed\n",
                               corename);
                        goto fail_unlock;
_

Patches currently in -mm which might be from [EMAIL PROTECTED] are

origin.patch
proc-export-a-processes-resource-limits-via-proc-pid.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to