The patch titled
     fallback to "no irq" hack for case of no pnp_irq allocated for 8250_pnp
has been added to the -mm tree.  Its filename is
     fallback-to-no-irq-hack-for-case-of-no-pnp_irq-allocated-for-8250_pnp.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: fallback to "no irq" hack for case of no pnp_irq allocated for 8250_pnp
From: "Luming Yu" <[EMAIL PROTECTED]>

There is a "ttyS1 irq is -1" problem observed on tiger4 which cause
the serial port broken.

It is because that there is __no__ ACPI IRQ resource assigned for the
serial port.  So the value of the IRQ for the port is never changed since
it got initialized to -1.  The attached patch falls back to the "no irq"
hack for this case.  It works for me.

Alan sayeth: "Should really fix pnp_irq() to use zero to mean none as the
kernel intends.  If that causes other complications then this hack will do for
now I guess."

Signed-off-by: Yu Luming <[EMAIL PROTECTED]>
Seems-reasonable-to: Matthew Wilcox <[EMAIL PROTECTED]>
Sort-of-acked-by: Alan Cox <[EMAIL PROTECTED]>
Might-be-the-fault-of: Bjorn Helgaas <[EMAIL PROTECTED]>
Cc: Russell King <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/serial/8250_pnp.c |    3 +++
 1 file changed, 3 insertions(+)

diff -puN 
drivers/serial/8250_pnp.c~fallback-to-no-irq-hack-for-case-of-no-pnp_irq-allocated-for-8250_pnp
 drivers/serial/8250_pnp.c
--- 
a/drivers/serial/8250_pnp.c~fallback-to-no-irq-hack-for-case-of-no-pnp_irq-allocated-for-8250_pnp
+++ a/drivers/serial/8250_pnp.c
@@ -433,6 +433,9 @@ serial_pnp_probe(struct pnp_dev *dev, co
 
        memset(&port, 0, sizeof(struct uart_port));
        port.irq = pnp_irq(dev, 0);
+       /* No irq is assigned for the port, fallback to "no irq" hack */
+       if (port.irq == -1)
+               port.irq = 0;
        if (pnp_port_valid(dev, 0)) {
                port.iobase = pnp_port_start(dev, 0);
                port.iotype = UPIO_PORT;
_

Patches currently in -mm which might be from [EMAIL PROTECTED] are

fallback-to-no-irq-hack-for-case-of-no-pnp_irq-allocated-for-8250_pnp.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to