The patch titled
     cgroup memory controller: document huge memory/cache overhead in Kconfig
has been added to the -mm tree.  Its filename is
     
cgroup-memory-controller-document-huge-memory-cache-overhead-in-kconfig.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: cgroup memory controller: document huge memory/cache overhead in 
Kconfig
From: Andi Kleen <[EMAIL PROTECTED]>

Document huge memory/cache overhead of memory controller in Kconfig

I was a little surprised that 2.6.25-rc* increased struct page for the
memory controller.  At least on many x86-64 machines it will not fit into a
single cache line now anymore and also costs considerable amounts of RAM. 
At earlier review I remembered asking for a external data structure for
this.

It's also quite unobvious that a innocent looking Kconfig option with a
single line Kconfig description has such a negative effect.

This patch attempts to document these disadvantages at least so that users
configuring their kernel can make a informed decision.

Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
Cc: Balbir Singh <[EMAIL PROTECTED]>
Acked-by: Paul Menage <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 init/Kconfig |    8 ++++++++
 1 file changed, 8 insertions(+)

diff -puN 
init/Kconfig~cgroup-memory-controller-document-huge-memory-cache-overhead-in-kconfig
 init/Kconfig
--- 
a/init/Kconfig~cgroup-memory-controller-document-huge-memory-cache-overhead-in-kconfig
+++ a/init/Kconfig
@@ -394,6 +394,14 @@ config CGROUP_MEM_CONT
          Provides a memory controller that manages both page cache and
          RSS memory.
 
+         Note that setting this option increases fixed memory overhead
+         associated with each page of memory in the system by 4/8 bytes
+         and also increases cache misses because struct page on many 64bit
+         systems will not fit into a single cache line anymore.
+
+         Only enable when you're ok with these trade offs and really
+         sure you need the memory controller.
+
 config PROC_PID_CPUSET
        bool "Include legacy /proc/<pid>/cpuset file"
        depends on CPUSETS
_

Patches currently in -mm which might be from [EMAIL PROTECTED] are

cgroup-memory-controller-document-huge-memory-cache-overhead-in-kconfig.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to