Hi

[2016-09-08 13:53] markus schnalke <[email protected]>
> The idea of your changes is good. On the first look, your
> code looks good as well.

I have looked at this code a bit. Yes the actually idea, separate
the code in different functions, is good.

I have a problem with the function ``append_alternate_mailboxes()''.
This function is almost the same as ``getmboxes()''. So I recommend
to change ``getmboxes()'' for your requirements and use this function
instead.

To the long names, I would recommend:
fill_mailname_type -> set_m_type
get_alternate_mailboxes -> altmboxes or alt_mboxes

Philipp

Reply via email to