[2017-03-05 19:52] Philipp Takacs <phil...@bureaucracy.de>
>
> I have written a patch for whom to accept msgs not only files. So with
> the patch you can write ``whom c'' instant of ``whom `mhpath c`''.

Great to see you working on the code! And sorry for my long
absence.

> I have
> attached the patch. I'll commit it after I have written a nice commit
> message in a few days.

I had not looked at your patch earlier but today the nightly
build crashed:

        parse_msgs.c: In function ‘parse_msgs’:
        parse_msgs.c:27:2: error: ‘for’ loop initial declarations are only 
allowed in C99 mode
        parse_msgs.c:27:2: note: use option -std=c99 or -std=gnu99 to compile 
your code
        parse_msgs.c:39:14: error: redefinition of ‘i’
        parse_msgs.c:27:14: note: previous definition of ‘i’ was here
        parse_msgs.c:39:2: error: ‘for’ loop initial declarations are only 
allowed in C99 mode
        make[1]: *** [parse_msgs.o] Error 1
        make[1]: Leaving directory `/tmp/mmh-nightly-build.uv1GWT/mmh/sbr'
        make: *** [all-recursive] Error 1


This made me have a look at it. (Was this your intention? ;-) )

Just fixed it:
        http://git.marmaro.de/?p=mmh;a=commitdiff;h=d9b9dba7a
        http://git.marmaro.de/?p=mmh;a=commitdiff;h=6e9577f32

... feels good to have touched on the code again. :-)



Please not that several tests now fail with the message:

        whom: Bug: message out of bounds

That's from assert_msg_range() within sbr/seq_msgstats.c.


meillo

Reply via email to