Issue 2812 in mobicents: Incorrect exception handling in TLSMessageProcessor

[mobicents]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2812 by lyo...@codeminders.com: Incorrect exception handling in  
TLSMessageProcessor
http://code.google.com/p/mobicents/issues/detail?id=2812

JAIN-SIP rev1962

In TLSMessageProcessor::run() SocketException could be thrown in two places:

1. Socket newsock = sock.accept()
2. incomingTlsMessageChannels.add(new TLSMessageChannel(newsock, sipStack,  
this, "TLSMessageChannelThread-" + nConnections))
that does SSL handshake

if SocketException is caught, thread execution is interrupted:

                  this.isRunning = false;
                  break;

I think that you should distinguish two cases, and if exception is thrown  
during SSL handshake (e.g. invalid certificate was supplied by client),  
then there is no need to stop thread execution, it's just a problem of  
particular SSL session.

Please find proposed patch in atachments

Thank you in advance

Attachments:
        patch.diff  2.0 KB