Comment #2 on issue 34 by [email protected]: Session based
Client Ro throws Null Pointer Exceptions if send fails in HA mode in
getGatheredRequestedAction()
http://code.google.com/p/jdiameter/issues/detail?id=34
The change from "setState(ClientRoSessionState.IDLE, true)"
to "setState(ClientRoSessionState.IDLE, false)" in my original patch is
wrong.
Step 4 in the original bug report is not a real issue, the
IllegalStateException can be caught at the application layer. My original
patch does prevent the IllegalStateException, but causes other problems. I
got carried away fixing exceptions...
The rest of the patch consists of moving gatheredRequestedAction and it's
initialization inside the code block for Event messages. Within this block
the absence of a Gathered Request Action is an error; outside this block it
is not required and not used.
I've attached the patch I am now using, which I believe is correct and
safe, and fixes the real issue for me.
Attachments:
ClientRoSessionImpl.diff 2.1 KB
