Comment #29 on issue 152 by [email protected]: Implement
insertSubscriberData MAP message
http://code.google.com/p/jss7/issues/detail?id=152
Hello!
1. About MAPParameterFactory: this patch looks good for me. The only thing
that I have not checked if all primitives that you have implemented (and
all choices constructors) are included in the patch. You can check it from
a primitive list from this issue (and insertRoutingInfo issue). It is a
good idea to include primitives into MAPParameterFactory just after they
have been implemented.
2. ChargingCheracteristic looks good for me
3. PDPAddress:
- We have to implement PDPType first of all. You can see details in 29.060
in "7.7.27 End User Address" chapter. It is simple. We need an extra enum
PDPTypeValue for PDPType values enumerating
- Using "String" in a constructor of PDPAddress and in "getAddressString()"
is a good idea. But for both cases we need an extra parameter -
PDPTypeValue:
PDPAddressImpl(String address, PDPTypeValue typeValue) { ... }
String getAddressString(PDPTypeValue typeValue);
- PPP case: it looks like it is just digits encoded by TbcdString. Look for
example here: http://en.wikipedia.org/wiki/X.121. I think we can add
TbcdString encoding/decoding at this step for PPP case.
We have to release jss7 BETA4 today. I will commit your MAPParameterFactory
patch now.
ChargingCheracteristic and PDPAddress/Type we will postpone to a next
release, please do not commit this now.
