Updates:
Status: Started
Comment #4 on issue 56 by jean.deruelle: keyStore and trustStore passwords
must be equal
http://code.google.com/p/jain-sip/issues/detail?id=56
Hi Jose,
I reviewed the patch. It looks good. I just have one comment though. To
avoid breaking backward compatibility with existing applications that use
only one password for both KeyStore and TrustStore, and which would fail to
init with this patch, I would actually set the truststorepassword to the
keystorePassword if the former is null.
See code in the attached counterpatch starting from line 58 :
// required, could use default trustStore, but it is better practice to
explicitly specify
+ final String trustStoreFilename =
properties.getProperty("javax.net.ssl.trustStore");
+ // optional, if not specified using keyStorePassword
+ String trustStorePassword =
properties.getProperty("javax.net.ssl.trustStorePassword");
+ if(trustStorePassword == null) {
+ logger.logInfo("javax.net.ssl.trustStorePassword is null, using
the password passed through javax.net.ssl.keyStorePassword");
+ trustStorePassword = keyStorePassword;
+ }
Attachments:
jain-sip-issue-56-counterpatch.patch 6.6 KB
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "mobicents-all-issues-changes" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
