Updates:
        Status: Started

Comment #6 on issue 81 by [email protected]: Implement updateGprsLocation MAP message
http://code.google.com/p/jss7/issues/detail?id=81

Hello!

I have checked both this update and update for sendIdentification MAP message (issue 250). Here is a cumulative reply:

1. you are insering somethere into a top new files
/*
 * JBoss, Home of Professional Open Source
 * Copyright 2011, Red Hat, Inc. and individual contributors
 * by the @authors tag. See the copyright.txt in the distribution for a
 * full listing of individual contributors.
isert instead fo it:
/*
 * TeleStax, Open Source Cloud Communications  Copyright 2012.
 * and individual contributors
 * by the @authors tag. See the copyright.txt in the distribution for a
 * full listing of individual contributors.


2. UpdateGprsLocationRequest, UpdateGprsLocationResponse : we do not need mapProtocolVersion here because only one version (3) is supported

3. Let's replace SendIdentificationRequest.getLmsi() with SendIdentificationRequest.getNewLmsi() (this is my fault)

4. SendIdentificationResponseImpl: if(mapProtocolVersion==2): in _decode():
  - imsi parameter is mandatory (unlike V3) - lets check it

5. MAPMessageType let's replace updateGprsLocationRequest -> updateGprsLocation_Request
and updateGprsLocationResponse -> updateGprsLocation_Response

6. updateGprsLocationResponse is mandatory. But MAPServiceMobility.updateGprsLocationResponse() accept this as optional.
Please fix it

7. addSendIdentificationRequest - should use _Timer_s (not _Timer_m)
Please fix it

Please fix this and commit your updates





--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--

--- You received this message because you are subscribed to the Google Groups "mobicents-all-issues-changes" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to