Comment #5 on issue 159 by [email protected]: Implementing CAP phase 3
operations for SMS
http://code.google.com/p/jss7/issues/detail?id=159
Hello!
1. continueSMS operation is not implemented. We need to add it into api too.
2. We need to add toString() methods in ALL implemented primitives (even
for example in empty primitive like OSmsSubmissionSpecificInfoImpl)
3. OSmsFailureSpecificInfoImpl, OSmsSubmissionSpecificInfoImpl,
TSmsFailureSpecificInfoImpl, TSmsDeliverySpecificInfoImpl,
FCIBCCCAMELsequence1Impl:
we do not need getTag() and getTagClass() here, instead we need to use such
tags definition in EventSpecificInformationSMSImpl
(EventSpecificInformationSMSImpl is well implemented)
4. FurnishChargingInformationSMSRequestImpl: _ID_eventTypeSMS and
_ID_eventSpecificInformationSMS are not needed
5. FurnishChargingInformationSMSRequestTest:
getData() must be: 4, 15, -96, 13, -128, 8, 48, 6, -128, 1, 3, -118, 1, 1,
-127, 1, 1
So there must not be eztra "Sequense" - this part - 48, 15
This is a bug from FurnishChargingInformationSMSRequestImpl
6. SMSAddressString needs extra implementing when alphanumeric character
string cause. Here ias specification:
SMS-AddressString ::= AddressString (SIZE (1 .. maxSMS-AddressStringLength))
-- This data type is used to transport CallingPartyNumber for MT-SMS.
-- If this data type is used for MO-SMS, then the maximum number of digits
shall be 16.
-- An SMS-AddressString may contain an alphanumeric character string. In
this
-- case, a nature of address indicator '101'B is used, in accordance with
-- 3GPP TS 23.040 [6]. The address is coded in accordance with the GSM 7-bit
-- default alphabet definition and the SMS packing rules as specified in
-- 3GPP TS 23.038 [15] in this case.
So if AddressString.getAddressNature()==AddressNature.reserved (=='101'B)
we have to make another implementation of encoding / decoding.
We have to override AddressString._decode() and encodeData().
For "AddressNature!=reserved" we will invoke corresponded super.*() methods
and
for reserved - implement our code.
We have already implemented such encoding in
org.mobicents.protocols.ss7.map.smstpdu.AddressFieldImpl (map stack) - look
please there for details
7. SMSEventImpl._ID_monitorMode 10 -> 1
8. TPValidityPeriodImpl: we have to implement an extra funtionality here:
- extra getter: org.mobicents.protocols.ss7.map.api.smstpdu.ValidityPeriod
getValidityPeriod();
- extra constructor with a parameter "ValidityPeriod"
New methods must contain encoding/decoding functionality.
org.mobicents.protocols.ss7.map.smstpdu.SmsSubmitTpduImpl contains decoding
(in SmsSubmitTpduImpl(byte[] data, Charset gsm8Charset))
and encoding (in encodeData()) templates
9. ConnectSMSRequestImpl.getMessageType() reeturns wrong value
10. EventReportSMSRequestImpl: eventTypeSMS paramater is mandatory - add
checking for it
11.ResetTimerSMSRequestImpl: getMessageType() and getOperationCode() return
wrong value
12. For SMS part we need to support CapV3_cap3_sms and CapV4_cap4_sms for
incoming and outgoing parts
13. CAPServiceImpl.connectSMSRequest() - doule lines:
((CAPServiceSmsListener) serLis).onConnectSMSRequest(ind);
((CAPServiceSmsListener) serLis).onConnectSMSRequest(ind);
14. CAPServiceImpl.resetTimerSMSRequest() getTag() != Tag.STRING_OCTET ->
SEQUESNCE
I will commit your update becaus ewe need this implementation is a short
time
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "mobicents-all-issues-changes" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
