Comment #6 on issue 312 by [email protected]: CAP InitialDP
empty (zero length) IMSI
http://code.google.com/p/jss7/issues/detail?id=312
I assumed jASN takes care of decoding base types, not only reading the
bytes (from experience with other ASN.1 tools) without actually looking at
the code. Sorry for muddying the waters.
Having looked at the code now, though :)
http://code.google.com/p/jss7/source/browse/cap/cap-impl/src/main/java/org/mobicents/protocols/ss7/cap/service/circuitSwitchedCall/InitialDPRequestImpl.java#610
does not seem to do anything useful.
This would be more readable and save a method call.
diff --git
a/cap/cap-impl/src/main/java/org/mobicents/protocols/ss7/cap/service/circuitSwitchedCall/InitialDPRequestImpl.java
b/cap/cap-impl/src/main/java/org/mobicents/protocols/ss7/cap/service/circuitSwitchedCall/InitialDPRequestImpl.java
index 93e9d8d..4f0b410 100644
---
a/cap/cap-impl/src/main/java/org/mobicents/protocols/ss7/cap/service/circuitSwitchedCall/InitialDPRequestImpl.java
+++
b/cap/cap-impl/src/main/java/org/mobicents/protocols/ss7/cap/service/circuitSwitchedCall/InitialDPRequestImpl.java
@@ -606,9 +606,7 @@ public class InitialDPRequestImpl extends
CircuitSwitchedCallMessageImpl impleme
break;
case _ID_iMSI:
int len = ais.readLength();
- if (len == 0) {
- ais.advanceElementData(len);
- } else {
+ if (len != 0) {
this.imsi = new IMSIImpl();
((IMSIImpl) this.imsi).decodeData(ais, len);
}
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "mobicents-all-issues-changes" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
