Status: New
Owner: ----
Labels: Type-Defect Priority-Medium Component-SS7 Roadmap-Fix
New issue 333 by [email protected]: MAP: MAPDialogState=INITIAL_RECEIVED
not handled correctly
http://code.google.com/p/jss7/issues/detail?id=333
Version: 2.0.0.FINAL
When sending a TC-CONTINUE to another SMSC after TC-BEGIN, the other SMSC
sent TC-CONTINUE with a forwardSM in it. But the MAP stack failed with:
Received TC-CONTINUE. MAPDialog=MAPDialog: LocalDialogId=13
RemoteDialogId=138228317 MAPDialogState=INITIAL_RECEIVED
MAPApplicationContext=MAPApplicationContext [Name=shortMsgMTRelayContext,
Version=version2, Oid=0, 4, 0, 0, 1, 0, 25, 2, ] TCAPDialogState=Active.
But state is neither InitialSent or Active
As can be seen, the status is actually INITIAL_RECEIVED, which I believe is
a valid state, but in the statement logging the error it is not handled:
In MAPProviderImpl.onTCContinue(TCContinueIndication tcContinueIndication):
// Now let us decode the Components
if (mapDialogImpl.getState() == MAPDialogState.InitialSent
|| mapDialogImpl.getState() == MAPDialogState.Active) {
[...]
} else {
// This should never happen
loger.error(String.format("Received TC-CONTINUE. MAPDialog=%s. But state is
neither InitialSent or Active",mapDialogImpl));
}
I believe this should be changed to:
// Now let us decode the Components
if (mapDialogImpl.getState() == MAPDialogState.INITIAL_SENT
|| mapDialogImpl.getState() == MAPDialogState.INITIAL_RECEIVED
|| mapDialogImpl.getState() == MAPDialogState.ACTIVE) {
[...]
} else {
// This should never happen
loger.error(String.format("Received TC-CONTINUE. MAPDialog=%s. But state
is neither InitialSent, InitialReceived or Active",
mapDialogImpl));
}
I've tested this patch myself and I now receive the SMS properly.
Kind regards,
Matthias van der Vlies
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "mobicents-all-issues-changes" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
