Comment #1 on issue 163 by jean.deruelle: Continues Overflow in
SSLStateMachine when unwrapping
https://code.google.com/p/jain-sip/issues/detail?id=163
I think the issue is that the overflow is not handled at all and keep
looping on a buffer of the same size. So your fix will make sure that the
CPU doesn't get to 100% as it will exit after a number of tries but will
not solve the issue of accepting the big packet I think which will lead to
lost calls or call setup.
I think a better fix would be to increase the buffer size and retry such as
the code snippet below
if(result.getStatus().equals(Status.BUFFER_OVERFLOW)) {
if(logger.isLoggingEnabled(LogWriter.TRACE_DEBUG)) {
logger.logDebug("Buffer overflow , must prepare the buffer again."
+ " outNetBuffer remaining: " + dst.remaining()
+ " outNetBuffer postion: " + dst.position()
+ " Packet buffer size: " + sslEngine.getSession().getPacketBufferSize()
+ " new buffer size: " + sslEngine.getSession().getPacketBufferSize() +
dst.position());
}
ByteBuffer newBuf =
channel.prepareAppDataBuffer(sslEngine.getSession().getPacketBufferSize() +
dst.position());
dst.flip();
newBuf.put(dst);
dst = newBuf;
if(logger.isLoggingEnabled(LogWriter.TRACE_DEBUG)) {
logger.logDebug(" new outNetBuffer remaining: " + dst.remaining()
+ " new outNetBuffer postion: " + dst.position());
}
continue;
}
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
---
You received this message because you are subscribed to the Google Groups "mobicents-all-issues-changes" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
