It's funny because the reason I wanted to do this was to make the code simpler because it meant that the mode argument would become 'final'.
But thanks for answering, I just wanted to check that I understand how Change Tracker is doing it's thing. Please note that the PR I submitted (https://github.com/couchbase/couchbase-lite-java-core/pull/284) works exactly along the lines you described. All I changed was cleaning up the arguments and making the code itself thread safe. Yaron ________________________________________ From: [email protected] <[email protected]> on behalf of Jens Alfke <[email protected]> Sent: Tuesday, September 23, 2014 10:03 PM To: [email protected] Cc: Traun Leyden Subject: Re: Normal and Longpoll > On Sep 23, 2014, at 4:02 PM, Yaron Goland <[email protected]> wrote: > > What's the harm? It seems like added complexity (including the timer) for no significant gain. Plus, the replicator code is complex enough that I don't change anything in it lightly. --Jens -- You received this message because you are subscribed to the Google Groups "Couchbase Mobile" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/mobile-couchbase/75B405A4-3A11-45C7-B60B-5985FD0A62ED%40couchbase.com. For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Couchbase Mobile" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/mobile-couchbase/1411574879070.71866%40microsoft.com. For more options, visit https://groups.google.com/d/optout.
