Here is my pull request: https://github.com/couchbase/couchbase-lite-ios/pull/561
--- Sébastien Arbogast http://sebastien-arbogast.com 2015-01-06 17:25 GMT+01:00 Sebastien ARBOGAST <[email protected]> : > Thanks a lot Jens. No worries: I know you have a lot on your plate and > what you are building is simply awesome. I just wanted to make sure I > hadn't missed something obvious before diving into a pull request. But I'll > definitely do that. By the way, about the small team problem, you should > have a look at your job application queue ;) > > --- > Sébastien Arbogast > http://sebastien-arbogast.com > > 2015-01-06 17:21 GMT+01:00 Jens Alfke <[email protected]>: > >> >> On Jan 6, 2015, at 7:43 AM, Sebastien ARBOGAST < >> [email protected]> wrote: >> >> All this seems overly complicated. Why doesn't +modelForDocument do it >> automatically? >> >> >> Because no one's thought of implementing it before, and because we're a >> small team and there's so much stuff to do. :/ >> Please file an issue requesting this functionality. (And if you're >> interested in implementing it, a pull request would be welcome.) >> >> It has the information from the modelFactory. It uses it to load a model >> of the right type from the document, it would make sense that it saves a >> document with the right type from a model, don't you think? >> >> >> Well, the "type" property is generally just a convention, not anything >> built-in. But you're correct that the ModelFactory uses this convention, so >> it would make sense for Model to use that too. >> >> —Jens >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Couchbase Mobile" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/mobile-couchbase/65C99C75-A169-41EA-B563-007ADE8B8438%40couchbase.com >> <https://groups.google.com/d/msgid/mobile-couchbase/65C99C75-A169-41EA-B563-007ADE8B8438%40couchbase.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Couchbase Mobile" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/mobile-couchbase/CAG1DMa9adkb83_tOHvifRjuzc4reBfEcAxX8KpfcvcQGWojBBg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
