Hello Pasin et Jens, Upon reflection, I think we do not have the same vision on CBLIS.
To describe the difference very quickly, below is an example. In CoreData you an invoice headers table and another table with invoice lines. An invoice with 2 lines. Your CBLIS will create a doc for the invoice header and 2 docs for each invoice line. My CBLIS will create a single doc. We will lose our time if I offer PR with my vision and generate human tensions. - Frédéric 2015-02-19 5:00 GMT+01:00 Pasin Suriyentrakorn <[email protected]>: > Hello F. Audon, > > I'm sorry to hear that my recent change to CBLIncrementalStore cause some > difficulty to merge on your side. > > I would like to clarify that we didn't ignore your PR, and recently I did > spend time study your PR and the related subjects to your PR (See #526 > <https://github.com/couchbase/couchbase-lite-ios/issues/526>). As your PR > is a feature enhancement to the CBLIncrementalStore, we couldn't just > review and merge the code like any other normal bug fix PRs. We would need > a proper review whether we would like to include the feature into the > product or not. > > -- Pasin > > On Wednesday, February 18, 2015 at 5:38:14 PM UTC-8, Manu Troquet wrote: >> >> Hello, >> I work to improve CBLIS. I think it is useless to submit the code via PR. >> You have so much to change the code since the publication of PR that it >> becomes impossible to merge the code. I think you should remove the olds PR >> because it's ridiculous to spend time on it. >> I am disappointed with the way you work. >> >> F. Audon aka Manu Troquet on GitHub > > -- > You received this message because you are subscribed to the Google Groups > "Couchbase Mobile" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/mobile-couchbase/ae8d0d98-e435-4ce2-9b17-f941d0dc9e8e%40googlegroups.com > <https://groups.google.com/d/msgid/mobile-couchbase/ae8d0d98-e435-4ce2-9b17-f941d0dc9e8e%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Couchbase Mobile" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/mobile-couchbase/CA%2B6CoCJ7MGQHfgkAfjw2veUUd1GbYXgnbd6eTSqynLdHp%2B5r0g%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
