Nice!

On Oct 30, 2014 7:52 PM, Nick Alexander <[email protected]> wrote:
>
> Hi folks, 
>
> I just landed Bug 1039902 which minifies (moHi folks,

I just landed Bug 1039902 which minifies (most of) Fennec's JavaScript.

You can see from [2] that there are only 5 files which don't currently 
minify (they are packaged un-minified) [3].

Be aware that no builds turn red if the list regresses.  I would like to 
get everything minifying so that we can turn builds red when something 
stops minifying, but that depends on getting a patch upstream to make 
the outstanding files to minify as well; and the JavaScript engine moves 
quickly so this might not be reasonable.  In the meantime, this list 
will regress quickly.

For comparison,

chocho:gecko nalexander$ curl --head 
http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/fx-team-android/1414713837/fennec-36.0a1.en-US.android-arm.apk
 
| grep Content-Length
Content-Length: 38343421

chocho:gecko nalexander$ curl --head 
http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/fx-team-android/1414703827/fennec-36.0a1.en-US.android-arm.apk
 
| grep Content-Length
Content-Length: 39796977

That's a tidy 1.4 meg difference.  I expect that difference to be much 
smaller above Nightly, though, because the Shumway JS minifies very well 
and is only included in Nightly.

Thanks to gps and glandium for helping to make this happen.

Yours,
Nick

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1039902

[2] 
https://tbpl.mozilla.org/php/getParsedLog.php?id=51479025&tree=Fx-Team&full=1

[3] snippet:

Warning: JS minification verification failed for 
../../../dist/bin/components/nsContentPrefService.js:
Warning: JS minification verification failed for 
../../../dist/bin/modules/ContentPrefService2.jsm:
Warning: JS minification verification failed for 
../../../dist/bin/modules/commonjs/sdk/deprecated/unit-test.js:
Warning: JS minification verification failed for 
../../../dist/bin/modules/commonjs/sdk/test/httpd.js:
Warning: 
/builds/slave/fx-team-and-000000000000000000/build/toolkit/mozapps/installer/js-compare-ast.js:18:24
 
SyntaxError: unterminated string literal
Warning: JS minification verification failed for 
../../../dist/bin/chrome/toolkit/content/global/aboutwebrtc/aboutWebrtc.js:
_______________________________________________
mobile-firefox-dev mailing list
[email protected]
https://mail.mozilla.org/listinfo/mobile-firefox-dev
_______________________________________________
mobile-firefox-dev mailing list
[email protected]
https://mail.mozilla.org/listinfo/mobile-firefox-dev

Reply via email to