Nice! I've been wanting this for so long. I'm most excited because this means we don't need to update hard-coded strings in the tests when we change them in the product (although I do see that we still need to hard-code the strings that come from .properties files that are used in JS, boo).
Margaret On Fri, Mar 20, 2015 at 6:01 PM, Michael Comella < [email protected]> wrote: > Hey, all. > > :imjalpreet made a revision to the StringHelper class such that it > initializes its' Strings using R.java [1]. This means we're no longer > duplicating the Strings that we're testing and no longer have to keep them > in sync - woo! > > The catch here is that StringHelper is now an instance instead of a class > housing many static String references. As such, you can now use > StringHelper as: > > StringHelper.get().STRING_NAME > > or, in class that extend BaseRobocopTest (e.g. the tests themselves): > > mStringHelper.STRING_NAME > > *Practically, this means is you can no longer use StringHelper.STRING_NAME > and, if you've been writing a test that uses a String, there's a very good > chance that you've been bitrotted.* *Sorry!* > > There are some follow-up bugs I have yet to file to clean up the loose > ends - you'll see those as the dependent bugs on [1]. > > Let me know if you have any questions. > - Mike (:mcomella) > > [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=938845 > > _______________________________________________ > mobile-firefox-dev mailing list > [email protected] > https://mail.mozilla.org/listinfo/mobile-firefox-dev > >
_______________________________________________ mobile-firefox-dev mailing list [email protected] https://mail.mozilla.org/listinfo/mobile-firefox-dev
