Is there trychooser syntax to include these jobs as part of try pushes? Margaret
On Fri, Mar 4, 2016 at 7:11 PM, Michael Comella <[email protected] > wrote: > Hello again. > > I just wanted to add if you fix all of the occurrences of lint issue, make > sure you add the check as an "error" (or remove the corresponding "warning" > override) in the `mobile/android/app/lint.xml` file [0]. This way if it's > ever regressed, it will get flagged as an error and burn the tree, rather > than getting flagged as a warning again. > > On that note, I landed a patch that added all checks that 1) we pass and > 2) isn't disabled by default into errors [1]. Yay! > - Mike (:mcomella) > > [0]: > https://mxr.mozilla.org/mozilla-central/source/mobile/android/app/lint.xml > [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1252717 > > On Fri, Mar 4, 2016 at 2:52 PM, Michael Comella < > [email protected]> wrote: > >> Hey all. >> >> Exciting news: android lint, which has been running under the "Unit" task >> with nalexander's latest Task Cluster additions (thanks Nick!), will now >> burn the tree if any checks marked "error" fail [1]. These checks will help >> us optimize our code and catch nasty bugs! >> >> To verify your changes against lint locally [2], run: >> ./mach gradle lint >> >> This is a tier 2 job, meaning you won't get backed out for failures, but >> a bug will be filed and requested to be fixed in the event that lint is >> regressed. Note that the failures currently look like unrelated >> intermittent issues in the treeherder summary (see [4]). >> >> This upgrade was implemented in [3]. >> >> What's next? >> * Lint failures don't give a descriptive summary in treeherder [4] >> * Some checks are implicitly warnings but are currently passing so we >> should change those to errors [5] >> * There are still many warnings – these issues should be fixed and >> changed to explicit "errors" >> * The end goal is to automatically change all warnings to errors [6] >> >> Follow the journey for squeaky clean code at the meta bug! [7] >> - Mike (:mcomella) >> >> [1]: specifically any checks within the "app" module. >> [2]: only the results from "app" module will burn the tree so run `./mach >> gradle app:lint` to get more specific results >> [3]: https://bugzilla.mozilla.org/show_bug.cgi?id=1238788 >> [4]: https://bugzilla.mozilla.org/show_bug.cgi?id=1253082 >> [5]: https://bugzilla.mozilla.org/show_bug.cgi?id=1252717 >> [6]: https://bugzilla.mozilla.org/show_bug.cgi?id=1253737 >> [7]: https://bugzilla.mozilla.org/show_bug.cgi?id=1170283 >> > > > _______________________________________________ > mobile-firefox-dev mailing list > [email protected] > https://mail.mozilla.org/listinfo/mobile-firefox-dev > >
_______________________________________________ mobile-firefox-dev mailing list [email protected] https://mail.mozilla.org/listinfo/mobile-firefox-dev
