5 seconds is the default.  The when_foo statements take arguments in
seconds, so you can say for example:

page.spinner_loading_element.when_not_present(20)
page.submit_button_element.when_present(15).click

There are many existing examples you can look at.

I wonder though if waiting more than 5 seconds for VE to process a
5-character diff in a short page is not a bug.  When we were looking at
using VE from within Flow, there was a large performance hit invoking VE
from outside.   We never investigated deeply because the Flow project chose
not to support VE until some later time.

-Chris






On Fri, Feb 7, 2014 at 12:42 PM, Jon Robson <[email protected]> wrote:

> I was on a phone when I looked at this - the videos don't work there so I
> was only looking at the screenshot. Yes looking at the video it does make
> more sense.
>
> The bit that _doesn't_ make sense is where the 5 seconds come from.
> The rule says this:
>
>     page.spinner_loading_element.when_not_present
>     page.submit_button_element.when_present.click
>
> Nothing about 5 seconds.. Waiting 5 seconds for the spinner to disappear
> is way too optimistic. VisualEditor can take much much longer than this
> especially on beta labs. I'd suggest 10 seconds maybe even 15 seconds -
> where does this number 5 come from?
>
> On a side note. I'm really concerned no one else other than me is paying
> notice to these mails as they are very noisy....
> I'm keen to see less of these e-mails and only see them when they actually
> show something is broken. Is there a possibility to only send the mails
> when it has been broken for 2 test runs to avoid issues due to the server?
>
>
>
>
>
> On Fri, Feb 7, 2014 at 11:29 AM, Chris McMahon <[email protected]>wrote:
>
>>
>>
>>
>>
>> On Fri, Feb 7, 2014 at 12:20 PM, Jon Robson <[email protected]>wrote:
>>
>>> Note sure why this failed. It works fine for me locally.... It's strange
>>> as the screenshot shows it got to the preview screen. Maybe the loader
>>> disappeared too fast?!
>>>
>>
>> It tells you exactly why it failed.  The message "timed out after 5
>> seconds, waiting for {:class=>"spinner loading", :tag_name=>"div"} to
>> disappear" seems perfectly clear to me, I hope it is to you also.  If you
>> click the "Screencast" tab of the SauceLabs display, you see the spinner on
>> the last step is present until the video ends.
>>
>> -Chris
>>
>>
>>  On 6 Feb 2014 23:00, <[email protected]> wrote:
>>>
>>>>   * FAILURE:
>>>> MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox Build #336
>>>> <https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/336/>
>>>> (Fri, 07 Feb 2014 06:28:34 +0000)*
>>>> *Test 
>>>> Result*<https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/336/testReport/>
>>>>  1 failed, 7 skipped
>>>>   Failed Tests  *Test Name**Duration**Age*  Encourage new users to
>>>> Keep Going.I see a KeepGoing message after completing my VisualEditor 
>>>> edit<https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/336/testReport/junit/(root)/Encourage%20new%20users%20to%20Keep%20Going/I_see_a_KeepGoing_message_after_completing_my_VisualEditor_edit>
>>>>  1
>>>> min 41 
>>>> sec6<https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/330/>
>>>>   All
>>>> Tests  *Package**Duration**Fail**Skip**Total*  
>>>> (root)<https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/336/testReport/junit/(root)>25
>>>> min1761
>>>>
>>>
>>
>
_______________________________________________
Mobile-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mobile-l

Reply via email to