During the retrospective the team decided to trial a more extreme approach to code review where we stop people from submitting new code whilst there is existing unreviewed code.
Following up from this I wrote a patch to introduce a pre-review hook that stops you submitting code until existing code is reviewed: https://gerrit.wikimedia.org/r/119327 It might seem a bit harsh but I think it's worth enforcing and seeing how we get on with it. We can always make it less strict or turn it off if we find it doesn't help us... On Mon, Mar 17, 2014 at 4:02 PM, Jon Robson <[email protected]> wrote: > The mobile web team ran a retrospective for its last iteration. I'm > sending it to mobile-l in case other teams out there are interested in > our working practices. In particular we tried out a "One word agile > retrospective" for a change. > > You can find the notes here [1]: > > Also I moved a few of the previous retrospectives to sub pages of this > page [2] to make them easier in future to find in future. Not sure if > the app team also wants to do this? > > > [1] > https://www.mediawiki.org/wiki/Wikimedia_mobile_engineering/Retrospectives/2014-03-17 > [2] https://www.mediawiki.org/wiki/Wikimedia_mobile_engineering/Retrospectives _______________________________________________ Mobile-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mobile-l
