Kaldari, Juliusz, and Max What's been your experience with this?
--tomasz On Thu, Mar 27, 2014 at 5:42 PM, Jon Robson <[email protected]> wrote: > We introduced a pre-review hook in mobile that makes it hard for you > to submit new code when there is existing code to review (check out > [1] if you are interested) > > The problem I find is it tells _me_ to do code review, but all the > patches belong to me so I can't review them. I can poke people and ask > them to review it, but this usually isn't fruitful as it results in > "I'll do that later" or "I'm busy right now". > > I feel that the pre-review hook is making me aware of other people's > patches more often but I've had to force override it a few times like > just now when I've found that I own all the existing patches (as I'm > scared I'll lose the patch or forget about the patch otherwise). This > actually has had the effect on me of investing time in other projects > like data analysis, mailing list discussions, coding on VectorBeta, > Limn and core rather than concentrating my energy on MobileFrontend. I > also feel reluctant to pick up new cards to work on when I'm in this > limbo state as I don't want to overwhelm the code review queue or end > up managing various patches that might conflict with each other. > > I feel like I've contributed less to the MobileFrontend project as a > result - not sure if this is a good or a bad thing. That said it is > certainly a frustrating thing for me as I want to work on it more... > > Something to think about. > > [1] > http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend/f73209dc946d306357ed6dff90c0a9ad1de0c263/scripts%2Fpre-review > > _______________________________________________ > Mobile-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/mobile-l _______________________________________________ Mobile-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mobile-l
