Updates have been made and merged with just "Log in" underlined. Next release anons will see the message about IP editing and be given a chance to Log in right there. Thanks Yuvi and Bernd for the assistance! Siebrand, thanks also for staying on top of the translations.
On Thu, Jul 10, 2014 at 9:27 AM, Adam Baso <[email protected]> wrote: > Patchset 7 does that already. However, Yuvi, you had mentioned use of a > CDATA block instead of the PS7's approach (%s string substitution like > other part of app coupled with new protective hack against intermingled > LTR/RTL causing misordered text). Yuvi, what would that CDATA need to look > like? Would it just have a magic string that we replace and to which we > attach the ClickableSpan? > > -Adam > > > > On Thu, Jul 10, 2014 at 9:08 AM, Dan Garry <[email protected]> wrote: > >> It'd be better for just the "Log in" text to be a link than for the whole >> thing to be underlined, as if the whole thing is underlined then we've got >> one message that's underlined and one that's not, which looks really odd. >> >> Are there any other solutions here? >> >> Dan >> >> >> On 10 July 2014 08:56, Adam Baso <[email protected]> wrote: >> >>> Thank you, perfect. To keep it simple for translators, I'll amend the >>> patch to underline the whole message "Edits will be attributed to the >>> IP address of your device. If you Log in, you will have more privacy." >>> >>> >>> On Thu, Jul 10, 2014 at 8:51 AM, Dan Garry <[email protected]> wrote: >>> >>>> I'm having trouble finding what exactly it is that I should be >>>> commenting on in that patch. gerrit isn't the best for this kind of >>>> discussion. So here's how the flow works on iOS: >>>> >>>> - This message is displayed if you're not logged in: "Edits will be >>>> attributed to the IP address of your device. If you Log in, you will >>>> have >>>> more privacy." >>>> - "Log in" should be blue so it looks like a link. The rest of the >>>> message should be normal text colour. Either just "Log in", or the >>>> entire >>>> message, should link to the log in form (whichever's easier). >>>> - If the person logs in, they should be taken back to where they >>>> were (the edit summary screen), and if they save then the edit will >>>> save. >>>> >>>> Does that answer any questions you have? If not, let me know what you >>>> need from me. :-) >>>> >>>> Dan >>>> >>>> >>>> On 10 July 2014 08:42, Adam Baso <[email protected]> wrote: >>>> >>>>> Currently, the Android app does not clearly disclose to users when >>>>> they're IP editing that their IP address will be publicly logged. >>>>> >>>>> Dan, would you please review the comments in >>>>> https://gerrit.wikimedia.org/r/#/c/143156/ and let us know how to >>>>> proceed? >>>>> >>>>> Thanks. >>>>> -Adam >>>>> >>>> >>>> >>>> >>>> -- >>>> Dan Garry >>>> Associate Product Manager for Platform and Mobile Apps >>>> Wikimedia Foundation >>>> >>> >>> >> >> >> -- >> Dan Garry >> Associate Product Manager for Platform and Mobile Apps >> Wikimedia Foundation >> > >
_______________________________________________ Mobile-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mobile-l
