Looks great. Assuming you've tested and it works feel free to +2 (I havent got zero setup locally)
On Fri, Aug 1, 2014 at 1:30 PM, Adam Baso <[email protected]> wrote: > Jon and Yuri, I think the following does it. Mind reviewing? > > https://gerrit.wikimedia.org/r/#/c/151206/ > > -Adam > > > On Wed, Jul 30, 2014 at 5:06 PM, Adam Baso <[email protected]> wrote: >> >> Thanks! Yuri and I will take a look. >> >> >> On Wed, Jul 30, 2014 at 4:49 PM, Jon Robson <[email protected]> wrote: >>> >>> Adam: Whilst we standardise on template languages we need to >>> distinguish between the types of template languages that currently >>> exist in the MediaWiki world e.g. handlebars and hogan >>> >>> https://gerrit.wikimedia.org/r/149360 is in the code review queue and >>> basically makes it mandatory to include a template language file >>> extension (previously it would default to hogan when none was >>> specified). >>> >>> Basically you have to rename all your template files from having a >>> .html extension to .hogan and update the ResourceLoader resource >>> modules. >>> >>> Mobile has already done this as have Flow. >>> I think Zero is the only other extension that uses them and I'm keen >>> not to break it. >>> >>> Next steps would be to get Gabriel's knockoff template language >>> integrated into the Mantle extension and allow extensions to give it a >>> go. >>> >>> That then gives us a clear path to migrating this to core once we've >>> decided on a standard template language. >> >> > -- Jon Robson * http://jonrobson.me.uk * https://www.facebook.com/jonrobson * @rakugojon _______________________________________________ Mobile-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mobile-l
