Ahh I would say that's a bug. These should only be added conditionally. Task created, thanks for letting us know! https://phabricator.wikimedia.org/T85007?workflow=create
On Fri, Dec 19, 2014 at 1:54 AM, Antoine Musso <[email protected]> wrote: > Le 19/12/2014 00:27, Jon Robson a écrit : >> Could you elaborate? The MobileFrontend extension should not depend on >> VisualEditor and if it does that's a bug... > > Hello, > > I tried running the tests using the following extensions together: > > - JsonConfig > - Mantle > - MobileApp > - MobileFrontend > - WikiGrok > - ZeroBanner > - ZeroPortal > > Which yields two failures: > > ResourcesTest::testMissingDependencies > The module 'ext.visualEditor.mobileViewTarget' required by > 'mobile.editor.ve' must exist > Failed asserting that an array contains 'ext.visualEditor.mobileViewTarget'. > > ResourcesTest::testUnsatisfiableDependencies > Undefined index: ext.visualEditor.mobileViewTarget > > https://integration.wikimedia.org/ci/job/mediawiki-phpunit-integration-hhvm/4/testReport/ > > Both solved when adding VisualEditor to the loop. The RL dependency is > indeed in MobileFrontend: > > cd MobileFrontend > $ git grep -n ext.visual > includes/Resources.php:352: 'ext.visualEditor.mobileViewTarget', > > > -- > Antoine "hashar" Musso > > > _______________________________________________ > Mobile-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/mobile-l _______________________________________________ Mobile-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mobile-l
