[mochikit] Re: escapeHTML not working as stated

[Bob Ippolito]

Yeah, don't do that. That's totally wrong anyway. _javascript_ code *is not* HTML! You need a function that escapes _javascript_ code.. or better yet, just create a closure. -bob On Jun 26, 2006, at 12:32 PM, Sean De La Torre wrote: It's not a markup issue; rather, it's an issue when creating function inputs from data retrieved from the server.  For example: // the current variable is an array. current[current.length] = A({'href': '#',                                         'id': 'help_desk_delete_' + item.id,                                'onclick':"confirmDeleteHelpDesk('" + item.name + "','" + item.id + "'); return false;"}, "Delete"); In the code snippet above, if "item.name" contains an apostrophe, it creates an invalid JS snippet for the onclick statement.  It's probably safer to only use the id to retrive the user text, but I'll take a look at that later. Sean On 6/26/06, Bob Ippolito <[EMAIL PROTECTED]> wrote: On Jun 26, 2006, at 12:08 PM, [EMAIL PROTECTED] wrote: > Only changing the docs is fine by me.  I just noticed the discrepancy > because I had a problem with an apostrophe and thought that escapeHTML > would take care of it for me.  Of course, it is probably just as easy > for me to replace it myself, but I was being lazy :) In what scenario would you have a problem with an apostrophe though? It's not used in any markup. -bob --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "MochiKit" group. To post to this group, send email to mochikit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/mochikit -~----------~----~----~----~------~----~------~--~---