On Jul 25, 2006, at 4:20 PM, Jorge Godoy wrote:
>
> Beau Hartshorne <[EMAIL PROTECTED]> writes:
>
>> You should probably be fine. That said, test it with say 5,000
>> rows and see
>> what happens, especially in IE. Firefox is not immune though, you
>> should test
>> it thoroughly too. If this breaks somehow, please open a new Trac
>> ticket and
>> attach your test case.
>
> There was no bug, but it wasn't fast enough to be completed without
> Firefox
> complaining about how long the script was taking to finish.
>
> The main code for my test is:
>
> for (var index; index < 400; index++) {
> var sample = index;
> log ('Sample:', sample);
> var elements = [sample,
> INPUT({'name':sample+':sample',
> 'id':sample+':sample'}, null),
> LABEL({'name':sample+':result',
> 'id':sample+':result'}),
> [INPUT({'name':sample+':ignore_sample',
> 'id':sample+':ignore_sample',
> 'value': true,
> 'type': 'checkbox'}, null),
> LABEL(null, 'Ignore Reading'),],
> ];
> extend(lines, new Array(elements));
> }
You should really never, ever, call "new Array". It's silly. In this
case the array you created is new anyway.. why?
Also, index isn't initialized to 0.. so the first run through is
going to be undefined... that can't be correct as written here.
> and later, in another function (after swapDOM...):
>
> for (var index; index < 400; index++) {
> var sample = index+':sample';
> connect(sample, 'onchange', calculate_results);
> }
>
>
> Any hints on how to make it better would be appreciated.
A full example that people could play with would help.
-bob
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"MochiKit" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/mochikit
-~----------~----~----~----~------~----~------~--~---
