MochiKit + cssQuery have been my standard JS libraries for a while now
so it would be really good to see something like cssQuery in MochiKit.
Thanks for the effort so far!

My only real comment is on the packaging and naming.

At the moment it's MochiKit.Selector.findChildElements(element,
expressions). I think MochiKit.DOM.getElementsBySelector(expression,
element=document) seems more in keeping with the rest of MochiKit.

MochiKit.DOM because I'm searching for DOM elements and it fits nicely
alongside getElement and getElementsByTagAndClassName.

element as the last arg, defaulting to document, because it makes it
more consistent with getElementsByTagAndClassName and covers the
common usecase of searching the whole document.

expression because I can't think of a time I've ever called cssQuery
with multiple expressions.

Hope the feedback is useful. Thanks again.

- Matt

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"MochiKit" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/mochikit
-~----------~----~----~----~------~----~------~--~---

Reply via email to