On 11/6/06, Ashish Agrawal <[EMAIL PROTECTED]> wrote:
>
> Bob can you download and check the JS code from
> http://www.agrawalinfotech.com/js/ColorPicker.js.
>
Yeah, I see the code... but your question didn't make any sense. The
code you posted would work fine. I think you'll have to phrase your
question differently -- e.g. by posting code that *actually* doesn't
do what you expect.
The only suggestion I really have for the code (at a glance) is that
you should be consistent about using fully qualified MochiKit names.
In a bunch of places you're using the short ones (appendChildNodes),
and other places you're using the long ones
(MochiKit.Signal.disconnect). It's kinda misleading.
The code would be shorter if you used short names everywhere.. the
only real reason to use fully qualified names everywhere is if you're
worried about conflicts with other libraries, in which case you should
not use any short names.
Also the code would be more readable if you didn't mix tabs and
spaces. Firefox's default tab stop isn't the same as what you wrote it
with. Using spaces everywhere is generally best. Most text editors can
be configured to expand tabs ("soft tabs").
-bob
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"MochiKit" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/mochikit?hl=en
-~----------~----~----~----~------~----~------~--~---
