Hi John,
On Mon, Oct 20, 2008 at 17:19, John Resig <[EMAIL PROTECTED]> wrote:
> Excellent list - I just integrated virtually all of your points:
> http://github.com/jeresig/sizzle/commit/93e33dc2a41e2b0aa0e1e1c66368f5d224da80e1
Excellent. Thanks!
> The exception is :visible and :hidden - which should be handled by the
> host library.
I agree.
> Also, I wrapped the entireity of Sizzle withing a (function(){ ...
> })() which means that no global variables are exposed (save for
> Sizzle).
>
> What specific code do you use to hook Sizzle in to your engine? What
> I'll probably do is just hook it directly in to the right spot (for
> example, overwrite jQuery.find, in the case of jQuery) rather than
> introduce a new global variable.
Actually, I copied the contents of Sizzle into Selector.js which is
part of MochiKit [1]. Integrating is then just a matter of calling
Sizzle(...) in the correct place in the Selector API. Our plan is to
completely remove the old Selector implementation, i.e. using Sizzle
won't be optional like it looks like your plan for jQuery is.
[1]
http://trac.mochikit.com/browser/mochikit/branches/selector_sizzle/MochiKit/Selector.js
I don't know what other MochiKitters say about including Sizzle.js as
a seperate file. Per, Bob?
cheers,
Arnar
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"MochiKit" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/mochikit?hl=en
-~----------~----~----~----~------~----~------~--~---
