Ok, perhaps I was a bit too optimistic with my change. It is correct
per the CSS spec, but IE6/7 is broken as usual. But it seems that IE8
cleans up a bit from the previous errors:
http://www.quirksmode.org/css/display.html
I guess the easy fix for this is to just set display to block whenever
we're in an IE browser. And fix the regressions later on when IE8
(final) gets released... Oh well...
/Per
On Mon, Nov 3, 2008 at 6:05 PM, bkc <[EMAIL PROTECTED]> wrote:
>
> I have a production site that is using this svn url:
> http://svn.mochikit.com/mochikit/trunk/packed/MochiKit/MochiKit.js via
> an external
>
> after the last svn update blindUp($(id)) isn't working (see details
> below)
>
> I have checked out a bunch of back revs. It works in rev 1448, fails
> in rev 1449 and onwards.
>
> It fails in IE7 and IE 6.1
>
> it does work fine w/ FF 2x
>
> it looks to me like getElementDimensions() has changed in 2 ways:
>
> 1. tries to set the style.display to something other than ""
> 2. tries to set the style.display for tables to "table" which
> apparently doesn't work in IE.
>
> ===
>
> so in rev 1449 I get the error in MochiKit.js line 4197
>
> working the callstack upwards from my code:
>
> if(new_state == 'closed') {
>
> blindUp($(id));
>
> if(indicator) {
>
> removeElementClass(indicator, 'hide');
>
> addElementClass(indicator, 'show');
>
> }
>
> IE debugger command window:
>
> id
>
> "master_headertable"
>
> typeof $(id)
>
> "object"
>
> $(id).id
>
> "master_headertable"
>
> up the callstack to blindUp()
>
> MochiKit.Visual.blindUp=function(_6d7,_6d8){
> var d=MochiKit.DOM;
> _6d7=d.getElement(_6d7);
> var _6da=MochiKit.Style.getElementDimensions(_6d7,true); /* line 6590
> fails here)
> var _6db=d.makeClipping(_6d7);
>
> it is failing in line 6590
>
> command window:
>
> typeof _6d7
>
> "object"
>
> _6d7.id
>
> "master_headertable"
>
> up the callstack to getElementDimensions
>
> getElementDimensions:function(elem,_448){
> var self=MochiKit.Style;
> var dom=MochiKit.DOM;
> if(typeof (elem.w)=="number"||typeof (elem.h)=="number"){
> return new self.Dimensions(elem.w||0,elem.h||0);
> }
> elem=dom.getElement(elem);
> if(!elem){
> return undefined;
> }
> var disp=self.getStyle(elem,"display");
> if(disp=="none"||disp==""||typeof (disp)=="undefined"){
> var s=elem.style;
> var _44d=s.visibility;
> var _44e=s.position;
> var _44f=s.display;
> s.visibility="hidden";
> s.position="absolute";
> s.display=self._getDefaultDisplay(elem); /* line 4197 fails here */
> var _450=elem.offsetWidth;
> var _451=elem.offsetHeight;
>
> failing at line 4197
>
> command window:
>
> elem.id
>
> "master_headertable"
>
>
> self._getDefaultDisplay(elem)
>
> "table"
>
> typeof s
>
> "object"
>
>
> s.display
>
> "none"
>
>
> s.position
>
> "absolute"
>
> /* try setting the display mode */
> s.display = 'block'
>
> "block"
>
>
>
> s.display = 'table'
>
> Could not get the display property. Invalid argument.
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"MochiKit" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/mochikit?hl=en
-~----------~----~----~----~------~----~------~--~---
