"Mark" <[EMAIL PROTECTED]> writes:

> mod_dtcl rocks!  Thanks for building it.

Thanks!
 
> ... so I've been using it for almost a year now.  Got a nice big
> system built on it.  Worked great during development.  But it's in
> production and now I'm getting this message from mod_dtcl: "Cannot
> manipulate headers - already sent".  It only does that when Apache
> has been idle for some extended period of time (at least an hour or
> two).  The first time I request a page I get that error.  Then when
> I request the same page again, and all pages that follow it,
> everything is fine.  Restarting Apache does NOT reproduce this error
> (but I expected it would).

> Any help appreciated...

Thanks for pointing this out, and sorry about the problem.

Found it:

--- mod_dtcl.c  18 Apr 2002 13:02:19 -0000      1.54
+++ mod_dtcl.c  2 Nov 2002 18:48:42 -0000
@@ -467,8 +467,7 @@
     {
        set_header_type(r, DEFAULT_HEADER_TYPE);
        print_headers(r);
-
-       return OK;
+       goto cleanup;
     }
 
     ap_cpystrn(error, DEFAULT_ERROR_MSG, sizeof(error));
@@ -589,6 +588,7 @@
 
     get_parse_exec_file(r, dsc, r->filename, 1);
     /* reset globals  */
+cleanup:
     *(dsc->buffer_output) = 0;
     *(dsc->headers_printed) = 0;
     *(dsc->headers_set) = 0;

Things weren't being cleaned up after someone did a HEAD request, and
then did a GET.

The above patch fixes the problem.  Committing to CVS as I send this
out...

-- 
David N. Welton
   Consulting: http://www.dedasys.com/
     Personal: http://www.dedasys.com/davidw/
Free Software: http://www.dedasys.com/freesoftware/
   Apache Tcl: http://tcl.apache.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to