I added my patch to the Trac ticket as well.  I'm not sure what process
you'd like us to follow for patches.

Cheers,
Bob


On Wed, Jan 6, 2010 at 2:26 PM, Bob Silverberg <[email protected]>wrote:

> Here's a patch:
>
> Index: ModelGlueConfiguration.cfc
> ===================================================================
> --- ModelGlueConfiguration.cfc (revision 64)
> +++ ModelGlueConfiguration.cfc (working copy)
> @@ -152,6 +152,9 @@
>  <cffunction name="setGeneratedViewMapping" returntype="void"
> output="false" access="public">
>   <cfargument name="GeneratedViewMapping" type="string" />
>   <cfset variables._instance.GeneratedViewMapping =
> arguments.GeneratedViewMapping />
> + <cfif
> listFind(arrayToList(variables._instance.ViewMappings),arguments.GeneratedViewMapping)
> eq 0>
> + <cfset arrayAppend(variables._instance.ViewMappings,
> arguments.GeneratedViewMapping) />
> + </cfif>
>  </cffunction>
>  <cffunction name="getGeneratedViewMapping" returntype="string"
> output="false">
>   <cfreturn variables._instance.GeneratedViewMapping />
>
>
> I'm using ArrayToList() which isn't very efficient, and could be replaced
> my using the underlying Java array's methods, but I figured that this code
> is going to run once, at init, and this array will never be very large.  The
> patch works as is, but feel free to tweak it if you like.
>
> Cheers,
> Bob
>
>
> On Wed, Jan 6, 2010 at 9:32 AM, Dennis Clark <[email protected]> wrote:
>
>> It worked in MG2, but does not work in the latest MG3 release.
>>
>> I just filed an issue for it: http://trac.model-glue.com/ticket/376
>>
>>  <http://trac.model-glue.com/ticket/376>FWIW I added
>> "backwards-compatibility" as an issue keyword. I set the severity to
>> "normal" since there is a known workaround, but I feel this ought to be
>> fixed quickly.
>>
>> Cheers,
>>
>> --
>> Dennis
>>
>>
>> On Tue, Jan 5, 2010 at 6:52 PM, denstar <[email protected]> wrote:
>>
>>> It's a bug.  :)
>>>
>>> --
>>> Every discourse, even a poetic or oracular sentence, carries with it a
>>> system of rules for producing analogous things and thus an outline of
>>> methodology.
>>> Jacques Derrida
>>>
>>> On Tue, Jan 5, 2010 at 12:12 PM, Bob Silverberg wrote:
>>> > I want my generated view files to be written to views/generated, so I
>>> > changed my Coldspring.xml file like so:
>>> >
>>> > <property
>>> > name="generatedViewMapping"><value>views/generated</value></property>
>>> >
>>> > This works for the writing of files: they do get written to that
>>> location.
>>> > However, when I try to run a scaffolded event, MG cannot find my view
>>> files.
>>> >  I get a message like:
>>> >
>>> > The template (List.Province.cfm) was not found in any registered view
>>> > mappings (/views).
>>> >
>>> > OK, so I manually added /views/generated to my view mappings in my
>>> > Coldspring.xml like so:
>>> >
>>> > <property
>>> > name="viewMappings"><value>/views,/views/generated</value></property>
>>> >
>>> > and now it's all working as expected.
>>> > However, the documentation
>>> > at
>>> http://docs.model-glue.com/wiki/HowTos/HowToUseScaffolds/CustomizingGeneratedCfml#Scaffolds:CustomizingGeneratedCFML
>>> > seems to suggest that I should not have to manually add that folder to
>>> my
>>> > viewMappings. It says:
>>> > "Scaffold tags cause certain files to be generated, such as lists,
>>> views,
>>> > and edit forms. This generated code is placed into a directory governed
>>> by
>>> > the ScaffoldPath property of the ModelGlueConfigurationBean in
>>> > ColdSpring.xml.
>>> >
>>> > Advanced note: The value of this setting is appended to the
>>> ViewMappings
>>> > setting, making this directory the last-searched directory when an
>>> include
>>> > tag is encountered."
>>> >
>>> > Now that statement is already inaccurate (I believe) as it is the
>>> > generatedViewMapping setting, not the scaffoldPath setting that
>>> determines
>>> > where the files will be written, but the note following it does seem to
>>> > suggest that the path I specify will be added to the viewMappings
>>> > automatically.
>>> > So, is this a bug, or just a misunderstanding on my part?  And if the
>>> > latter, does it still seem like a good feature to add?
>>> > Cheers,
>>> > Bob
>>> > --
>>> > Bob Silverberg
>>> > www.silverwareconsulting.com
>>> >
>>> > --
>>> > Model-Glue Sites:
>>> > Home Page: http://www.model-glue.com
>>> > Documentation: http://docs.model-glue.com
>>> > Bug Tracker: http://bugs.model-glue.com
>>> > Blog: http://www.model-glue.com/blog
>>> >
>>> > You received this message because you are subscribed to the Google
>>> > Groups "model-glue" group.
>>> > To post to this group, send email to [email protected]
>>> > To unsubscribe from this group, send email to
>>> > [email protected]<model-glue%[email protected]>
>>> > For more options, visit this group at
>>> > http://groups.google.com/group/model-glue?hl=en
>>> >
>>>
>>> --
>>> Model-Glue Sites:
>>> Home Page: http://www.model-glue.com
>>> Documentation: http://docs.model-glue.com
>>> Bug Tracker: http://bugs.model-glue.com
>>> Blog: http://www.model-glue.com/blog
>>>
>>> You received this message because you are subscribed to the Google
>>> Groups "model-glue" group.
>>> To post to this group, send email to [email protected]
>>> To unsubscribe from this group, send email to
>>> [email protected]<model-glue%[email protected]>
>>> For more options, visit this group at
>>> http://groups.google.com/group/model-glue?hl=en
>>>
>>
>>
>> --
>> Model-Glue Sites:
>> Home Page: http://www.model-glue.com
>> Documentation: http://docs.model-glue.com
>> Bug Tracker: http://bugs.model-glue.com
>> Blog: http://www.model-glue.com/blog
>>
>> You received this message because you are subscribed to the Google
>> Groups "model-glue" group.
>> To post to this group, send email to [email protected]
>> To unsubscribe from this group, send email to
>> [email protected]<model-glue%[email protected]>
>> For more options, visit this group at
>> http://groups.google.com/group/model-glue?hl=en
>>
>
>
>
> --
> Bob Silverberg
> www.silverwareconsulting.com
>



-- 
Bob Silverberg
www.silverwareconsulting.com
-- 
Model-Glue Sites:
Home Page: http://www.model-glue.com
Documentation: http://docs.model-glue.com
Bug Tracker: http://bugs.model-glue.com
Blog: http://www.model-glue.com/blog

You received this message because you are subscribed to the Google
Groups "model-glue" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/model-glue?hl=en

Reply via email to