From: Carlo Lobrano <c.lobr...@gmail.com> Hi,
here's my new version of the patch, according to the previous code review: - it uses context in place of the plugin's private structure - response parser in a separate helper file (with tests) - errors are handled - I replaced the at_sequence with a state machine Thank you, Carlo Lobrano Carlo Lobrano (1): Telit plugin: add load_unlock_retries interface plugins/Makefile.am | 18 +- plugins/telit/mm-broadband-modem-telit.c | 192 ++++++++++++++++++++++ plugins/telit/mm-modem-helpers-telit.c | 77 +++++++++ plugins/telit/mm-modem-helpers-telit.h | 25 +++ plugins/telit/tests/test-mm-modem-helpers-telit.c | 101 ++++++++++++ 5 files changed, 412 insertions(+), 1 deletion(-) create mode 100644 plugins/telit/mm-modem-helpers-telit.c create mode 100644 plugins/telit/mm-modem-helpers-telit.h create mode 100644 plugins/telit/tests/test-mm-modem-helpers-telit.c -- 2.1.4 _______________________________________________ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel