On Wed, 2016-10-12 at 13:49 +0200, Aleksander Morgado wrote: > Hey Dan & everyone, > > This is the 3rd update on the 'aleksander/ublox' branch, with this > additional changes done after Dan's last review: > > * Recovered the original DENIED registration state logic. > * Implemented a generic +CFUN parser and then included > plugin-specific parsers for the ublox, linktop and mbm plugins, > including unit tests. > * Fixed the +UPINCNT patches which had some code squashed in the > wrong commit. > * Fixed RSRQ logic in +CESQ parser. > * Updated +UBANDSEL parser to use g_strchomp() to get rid of > trailing > whitespaces, including CR and LF. > > Reviews of the implementation are more than welcome. > https://cgit.freedesktop.org/ModemManager/ModemManager/log/?h=aleksan > der/ublox
Changes look good to me! Dan _______________________________________________ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
