Hi Aleksander, 2017-03-13 17:44 GMT+01:00 Aleksander Morgado <aleksan...@aleksander.es>: > On Mon, Mar 13, 2017 at 5:33 PM, Dan Williams <d...@redhat.com> wrote: >>> Adding the vendor string match allows us to support RS232 devices in >>> the Telit plugin: the USB vendor id check may now be ignored and >>> instead we probe for the vendor string via AT commands, which works >>> even if the device is behind a USB<->RS232 adapter. >>> >>> https://bugs.freedesktop.org/show_bug.cgi?id=100171 >>> --- >>> >>> Hey hey, >>> >>> This patch enables support for RS232 modems in the Telit plugin; this >>> is, modems that are connected to a system via a RS232 port, or via a >>> USB<->RS232 adapter. >>> >>> Comments? >> >> Should this be paired with a patch adding Gobi capability to the telit >> driver, so that we don't capture Gobi-type devices as AT-only? Or is >> that not a problem? >> >> (eg, per our discussion about just using vendor ID instead of udev >> tags; this is the same result just different approach, no?) > > No, that's unrelated to our IRC discussion, I still plan in looking at > trying to remove the necessity of the TELIT udev flag. > > With this patch on, a Telit RS232 modem still needs the udev tag in > the appropriate port to get it grabbed by the Telit plugin. Without > this patch, the telit plugin would not grab this patch even if the > udev tag is set because the vid/pid filter would filter it out. >
It seems good to me, since, as far as I understand it looks like the only way for using use a Telit RS232-based modem: if needed I can do a quick test with one of those modems. Thanks, Daniele > -- > Aleksander > https://aleksander.es _______________________________________________ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel